Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a11y focus change on iOS #6095

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 15, 2025

Proposed changes

We were facing some issues with a11y focus on iOS. The problematic case involved the FormTextInput component with secureTextEntry enabled, as VoiceOver was reading the entire component instead of focusing first on the input and then on the "Show Password" button.

To fix this, I created a native module that receives an array of organized React tags for the elements and updates the accessibilityElements property of the parent view.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-200

How to test or reproduce

  • Open the app;
  • Navigate to loginView;
  • Turn on the VoiceOver;
  • Try focusing on the password input, then move to the next element;
  • it should be the "Show Password" button;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title test: a11y focus react tag poc chore: a11y focus on iOS Jan 21, 2025
@OtavioStasiak OtavioStasiak changed the title chore: a11y focus on iOS chore: a11y focus change on iOS Jan 21, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 24, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant