Add x11/wayland as cargo/meson features/options #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanksss! Looks good to me overall. I'll do a deeper review once I have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using Gentoo and noticed that the ebuild on GURU was outdated and looking for a new maintainer. I've had a look at it and tried to emerge it on my system but it failed because it has a dependency to X11 in every cases.
It's isn't a blocking issue but that means it would "force" to build GTK4 and some gstreamer plugins with X even altough X isn't used on the system.
It's true I could apply a patch on the ebuild but I thought it wouldn't be bad to try up-streaming it since it could benefit to others.
Please let me know what you think about these changes, I left the default with both enabled so it shouldn't affect flatpak users :)