Skip to content

Commit

Permalink
ci: move the type-checking out of the build process (#393)
Browse files Browse the repository at this point in the history
ci: move the type-checking out of the build process
  • Loading branch information
SeanCassiere authored Jul 29, 2024
1 parent bb40c12 commit 496aca4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

# This step runs the ci script for type-level errors.
- name: Run the tsc compiler to check for type-level errors
run: pnpm ci:typecheck

# This step runs the ci script for linting to check for linting errors.
- name: Run the linter to check for linting errors
run: pnpm ci:lint
Expand Down
18 changes: 10 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,21 @@
"private": true,
"type": "module",
"scripts": {
"start": "vite preview --host localhost --port 3000",
"build": "pnpm run clean && pnpm run build:code",
"build:code": "vite build",
"ci:format": "pnpm run format",
"ci:lint": "pnpm run lint",
"ci:typecheck": "pnpm run typecheck",
"clean": "rimraf ./dist && rimraf ./coverage",
"dev": "vite",
"lint": "eslint --max-warnings 0 .",
"lint:fix": "eslint --fix --max-warnings 0 .",
"format": "prettier --check './src/**/*.{js,jsx,ts,tsx,css,md,json}' --config './prettier.config.cjs'",
"format:fix": "prettier --write './src/**/*.{js,jsx,ts,tsx,css,md,json}' --config './prettier.config.cjs'",
"clean": "rimraf ./dist && rimraf ./coverage",
"build:code": "tsc && vite build",
"build": "pnpm run clean && pnpm run lint && pnpm run build:code",
"lint": "eslint --max-warnings 0 .",
"lint:fix": "eslint --fix --max-warnings 0 .",
"postbuild": "node ./postbuild.cjs",
"preview": "vite preview --port 3000",
"ci:lint": "pnpm run lint",
"ci:format": "pnpm run format"
"start": "vite preview --host localhost --port 3000",
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@dnd-kit/core": "^6.1.0",
Expand Down

0 comments on commit 496aca4

Please sign in to comment.