Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gaia ID in other functionalities #4064

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

henrysky
Copy link
Contributor

@henrysky henrysky commented Jan 9, 2025

Currently the support of Gaia ID is limited in other functionalities like displaying star name. The fact that Hipparcos and Gaia ID will not overlap means one can just check if the number specify in the file is larger than the possible Hipparcos ID to infer that is a Gaia ID. And current column for Hipparcos in data files can be mixed with Gaia ID directly.

So far, I have added Eta Carinae (Gaia DR3 5350358584482202880) as a test and added support for Gaia ID to asterism.

cross-id.dat is updated to include all SAO stars with their corresponding Gaia DR3, HD, HR if no already in the file.

Fixes #4043
Fixes #633

Screenshots (if appropriate):

1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111, alex-w and gzotti January 9, 2025 02:00
@henrysky henrysky changed the title initial support for Gaia ID for star name and asterism Support for Gaia ID in other functionalities Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

src/core/modules/StarMgr.hpp Outdated Show resolved Hide resolved
src/core/modules/StarMgr.hpp Outdated Show resolved Hide resolved
@gzotti
Copy link
Member

gzotti commented Jan 9, 2025

Interesting, I had not realized there was no overlap. So Gaia numbers start with a higher number than the highest HIP? This may make things easier. @sushoff, @10110111 this may also be important for any Skyculture definitions!

@alex-w alex-w added this to the 25.1 milestone Jan 9, 2025
@henrysky
Copy link
Contributor Author

henrysky commented Jan 10, 2025

Interesting, I had not realized there was no overlap. So Gaia numbers start with a higher number than the highest HIP? This may make things easier. @sushoff, @10110111 this may also be important for any Skyculture definitions!

There is no official start number of Gaia but practically the lowest Gaia source id is 4295806720 for DR3 in the whole DR3 catalog (not just stellarium). In order for a Gaia star in any data release to even has a source id lower than 34359738368, it need to fall within a specific area 0.7 arcmin2 of the sky. Hence I think it is safe to say the lowest Gaia source in the future data relase will bigger than the biggest HIP id.

I have updated the cross-id.dat to include all SAO stars if not already in the file. I think this PR is ready to be reviewed.

@henrysky henrysky marked this pull request as ready for review January 10, 2025 04:44
@github-actions github-actions bot requested a review from gzotti January 10, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The new star catalog should display more information Eta Carinae should be labeled with a name.
4 participants