feat(QTDI-693): manage nested jars #969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 17, 2024 11:34
This comment has been minimized.
This comment has been minimized.
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
| .filter(Files::exists) | ||
| .orElseGet(() -> PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository")); | ||
| // if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar | ||
| if (PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository").equals(rootRepo)) { |
There was a problem hiding this comment.
M2 repository path can be ovewritten by in settings.xml file
=> ${user.home}/.m2/repository might not be a path to the repository.
| new BufferedReader(new InputStreamReader(url.openStream()))) { | ||
| config.load(reader); | ||
| filter = createScanningFilter(config); | ||
| alreadyScannedClasses = config.getProperty("classes.list"); |
There was a problem hiding this comment.
should we "break" when we find the nested resource and create "filter" and "alreadyScannedClasses"?
because otherwise in case if we find more, the previous values will be overwritten
should we accumulate it maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-693