Fix datetime export format #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with no pytz dependencies |
dlenski
reviewed
Dec 16, 2020
| return date.replace(tzinfo=UTC) | ||
|
|
||
|
|
||
| class UTC(datetime.tzinfo): |
There was a problem hiding this comment.
🤔
Why not just use the built-in datetime.timezone.utc?
from datetime import timezone
UTC = timezone.utcThere was a problem hiding this comment.
I believe I was using python 2.7 at the time.
Should I fix this? Seven years with no activity sound like no one is particularly interested.
There was a problem hiding this comment.
Yeah, sorry, I noticed that after reviewing this. 🤦♂️ 😂
BTW, I looked into this myself, and all of the timestamps used in fittotcx (lap start, activity ID, and GPS timestamp) are already in UTC… so I wonder how an offset can get in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes I was getting one hour early times.