feat: add Certificates store and validation #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siepra
commented
Nov 15, 2023
| @@ -3,6 +3,7 @@ import { registerDecorator, ValidationArguments, ValidationOptions } from 'class | |||
| import Logger from '../common/logger' | |||
|
|
|||
| const logger = Logger('registration.validators') | |||
|
|
|||
| export function IsCsr(validationOptions?: ValidationOptions) { | |||
There was a problem hiding this comment.
Do I get it right, that we want to introduce the same method for certificate? Also, what are we particularly interested in validating inside CertificateContainsFields?
siepra
commented
Nov 15, 2023
packages/backend/src/nest/storage/certificates/certificates.store.ts
Outdated
Show resolved
Hide resolved
siepra
commented
Nov 15, 2023
siepra
commented
Nov 15, 2023
siepra
commented
Nov 15, 2023
siepra
commented
Nov 15, 2023
|
At this stage, I've moved logic related to certificates out of storage service into their own store.
|
|
At this step automatic tests are passing and the app seemed to work fine when tested manually. |
siepra
changed the title
4 tasks
This reverts commit 73c4f8d.
This reverts commit 64d64c0.
EmiM
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: