Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert github runners for E2E tests #2082

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: Revert github runners for E2E tests #2082

merged 1 commit into from
Nov 21, 2023

Conversation

leblowl
Copy link
Contributor

@leblowl leblowl commented Nov 17, 2023

Use the github provided runners for now because the E2E tests are expensive to run and it's unclear how much value the larger runner provides. Tor seems to cause a lot of variability in test run time. We are still using the larger Linux runner for the Android build.

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Use the github provided runners for now because the E2E tests are
expensive to run and it's unclear how much value the larger runner
provides. Tor seems to cause a lot of variability in test run time. We
are still using the larger Linux runner for the Android build.
@leblowl leblowl merged commit 4dea5a9 into develop Nov 21, 2023
6 of 8 checks passed
@siepra siepra deleted the fix-ci-runners branch December 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants