Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e test for invitation link; #2126

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: e2e test for invitation link; #2126

merged 2 commits into from
Nov 30, 2023

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Nov 29, 2023 •
edited
Loading

chore: move DATA_DIR related statics to common package

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

EmiM added 2 commits November 29, 2023 16:52
@EmiM
fix: e2e test for invitation link;
70892e9 
chore: move DATA_DIR related statics to common package
@EmiM
chore: cleanup
d84abb9
@EmiM EmiM marked this pull request as ready for review November 29, 2023 15:55
@EmiM EmiM requested review from Kacper-RF and vinkabuki November 29, 2023 15:55
@EmiM EmiM mentioned this pull request Nov 29, 2023
Closed
Kacper-RF
Kacper-RF approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmiM EmiM merged commit 5ddbc6a into develop Nov 30, 2023
18 of 23 checks passed
@siepra siepra deleted the fix/2040-new-data-dir branch December 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF approved these changes

@siepra siepra siepra approved these changes

@vinkabuki vinkabuki Awaiting requested review from vinkabuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmiM @siepra @Kacper-RF