Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup username creation component #2216

Merged
merged 7 commits into from
Jan 16, 2024
Merged

fix: cleanup username creation component #2216

merged 7 commits into from
Jan 16, 2024

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Jan 12, 2024 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Description

Solves #2156

@siepra
Copy link
Contributor Author

siepra commented Jan 12, 2024 •
edited
Loading

Things left to do in this PR:

  • Write/fix tests for the component and corresponding containers
  • Check if username registration works fine (self-QA)

@siepra siepra requested review from EmiM and leblowl January 15, 2024 16:07
leblowl
leblowl approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are some failing tests related to the change, otherwise looks good to me.

@siepra
Copy link
Contributor Author

siepra commented Jan 16, 2024

It looks like there are some failing tests

Right, it seems newly created test is passing locally but failing on CI... I'll just remove it to limit the amount of time spent on this task

@siepra siepra merged commit 1d03995 into develop Jan 16, 2024
19 of 24 checks passed
siepra added a commit that referenced this pull request Jan 17, 2024
@siepra
fix: cleanup username creation component (#2216)
1082c57 
* fix: cleanup username creation component

* fix: lint and test

* fix: split username registration component

* fix: tests

* chore: update CHANGELOG.md

* test: remove non-deterministic test
@siepra siepra deleted the fix/2156 branch January 17, 2024 12:51
leblowl pushed a commit that referenced this pull request Jan 18, 2024
@siepra
fix: cleanup username creation component (#2216)
c93e7b5 
* fix: cleanup username creation component

* fix: lint and test

* fix: split username registration component

* fix: tests

* chore: update CHANGELOG.md

* test: remove non-deterministic test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

@EmiM EmiM Awaiting requested review from EmiM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siepra @leblowl