resize: Respect client minimum and maximum sizes #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so decorators render correctly in these cases.
soreau
force-pushed
the
client-min-max-resize
branch
2 times, most recently
from
f8707d3 to
74cb5db
Compare
ammen99
reviewed
Dec 19, 2024
| if (max_size.width > 0) | ||
| { | ||
| desired.width = | ||
| std::min(max_size.width - |
There was a problem hiding this comment.
Why the subtraction here? max_size is what the client reports, but our full geometry can grow to client_max_size + margins from the decoration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so decorators render correctly in these cases.