touch: make EDGE_SWIPE_THRESHOLD configurable #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammen99
requested changes
Dec 19, 2024
| <_short>Touchscreen edge swipe threshold</_short> | ||
| <_long>Change the threshold of the built-in edge swipe detection. Higher values mean that a bigger area on the edge is used to trigger the edge swipe.</_long> | ||
| <default>10</default> | ||
| <min>5</min> |
There was a problem hiding this comment.
I would make this 1 or so .. let the users have more freedom :)
| @@ -427,24 +426,25 @@ static uint32_t find_swipe_edges(wf::touch::point_t point) | |||
| { | |||
| auto output = wf::get_core().seat->get_active_output(); | |||
| auto geometry = output->get_layout_geometry(); | |||
| wf::option_wrapper_t<int> edge_swipe_threshold{"input/edge_swipe_threshold"}; | |||
There was a problem hiding this comment.
This will cause a lookup for the option every time the function is called. I would make it a static wf::option_wrapper_t<...> so that it loads only the first time the function is called :)
There was a problem hiding this comment.
Thanks, will fix up after new year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile device with High-DPI screens and different scaling it would make sense to make that value configurable.