cube: add touch controls #2521
Open
cube: add touch controls #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename pointer_moved(ev->event) to rotate_cube(double xDiff, double yDiff), on_motion_event and on_touch_motion can call same function to rotate the cube.
ammen99
requested changes
Dec 19, 2024
|
|
||
| ev->event->delta_x = 0; | ||
| ev->event->delta_y = 0; | ||
| ev->event->unaccel_dx = 0; | ||
| ev->event->unaccel_dy = 0; | ||
| }; | ||
|
|
||
| void pointer_moved(wlr_pointer_motion_event *ev) | ||
| wf::signal::connection_t<wf::input_event_signal<wlr_touch_down_event>> on_touch_down = |
There was a problem hiding this comment.
Have you tried using the normal 'grabs' for getting touch events intead of connecting to the low-level input signals? See for example how expo and scale do it.
We use the low-level signals for pointer input because we need to lock the pointer in place. For touch, we don't really need this, so it is better to use the 'usual' interfaces if possible. The change shouldn't be hard, just specify this as the touch interface for the input grab constructor, then implement the touch interface for cube and you'll be getting input events while the grab is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds touchscreen controls to the cube. In the current state a tap is used to deactivate the plugin, so you can lift the finger and touch/move again to rotate.