input method: don't forward key-release without correspinding key-press #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit e2189903 in wlroots, when ctrl-f is pressed in firefox with a IME client running, the following key-release event for "f" is not sent, thus "f" is repeated like "ffffffffff..." in the input box of firefox. This is because the key-release event for "f" is firstly forwarded to the IME client and then sent via the virtual keyboard created by the IME client while the preceding key-press event is sent via physical keyboard, and with e2189903, key-release events without a corresponding key-press event on the same keyboard is not emitted to the compositor. So this commit fixes this problem by not forwarding the key-release event to the IME client unless the corresponding key-press event was also forwarded.
tokyo4j
force-pushed
the
fix/firefox-fcitx5-key-repeat
branch
from
605a88e to
96f12f5
Compare
tokyo4j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the fix in labwc/labwc#2437.
After commit e2189903 in wlroots, when ctrl-f is pressed in firefox with a IME client running, the following key-release event for "f" is not sent, thus "f" is repeated like "ffffffffff..." in the input box of firefox.
The video below is the demonstration of the regression in labwc, but it also happens in wayfire:
2024-12-16.16-13-45.mp4
This happens in the following flow:
So this PR fixes this problem by not forwarding the key-release event to the IME client unless the corresponding key-press event has also been forwarded.