Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to partially address #865 and clean up some inconsistencies in the font-related verbs.
w_try_cp_font_files
, which makes sure that we don't get the same font file but with different casing underC:\windows\Fonts
. It also forces lower case for font names to help alleviate duplication issues.chmod +w "${W_FONTSDIR_UNIX}"/tahoma*.ttf
since no app should be allowed to overwrite fonts. I'd rather have this posted as a workaround on https://appdb.winehq.org/ instead of maintaining it in Winetricks.w_try_cabextract
already passes-q
to cabextract.Note: Since eufonts only updates trebucbd.ttf, allfonts will skip installing eufonts after this PR, since trebucbd.ttf is installed in advance by corefonts. #885 needs to be addressed in order to fix this.
Note2: eufonts is an update to some of the fonts installed by corefonts, so corefonts should always be installed first. Luckily, allfonts installs them in the right order.
As a reference, here is the difference between installed font files based on this PR:
original_font_files.txt
updated_font_files.txt
And here is the difference in registry entries:
original_windows_nt.txt
updated_windows_nt.txt
The observed differences in the registry are due to the fact that eufonts was not installed as explained above.
As described in CONTRIBUTING.md (#871), I ran
./tests/shell-checks
successfully and I skippedwinetricks-test
, since it didn't work as described. See here.