Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background + welcome widget border #8152

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

audrasjb
Copy link
Contributor

This is related to https://core.trac.wordpress.org/ticket/62831.

I noticed that the white background was removing the background difference between the welcome panel (the section with a white background).

1-welcome-without-border

While it doesn't look shocking to me, this PR also adds a border to the welcome widget.

2-welcome-with-black-border

This is the only issue I found while testing this changeset.
More tests are welcome!

@audrasjb audrasjb requested a review from karmatosed January 21, 2025 11:03
Copy link

github-actions bot commented Jan 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@audrasjb
Copy link
Contributor Author

I pushed a follow-up commit to the PR to also use white background on alternative color schemes. Maybe we can choose to keep a grey background on some of them, though.

@audrasjb
Copy link
Contributor Author

@karmatosed do you have any preference for the welcome box? Black border or no border?
That's a detail we can still update later though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant