-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizer: Fix input field widths and alignment for date-time controls #8178
base: trunk
Are you sure you want to change the base?
Customizer: Fix input field widths and alignment for date-time controls #8178
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
||
.wp-core-ui .date-time-fields .day-fields.clear select, | ||
.wp-core-ui .date-time-fields .time-fields.clear select { | ||
vertical-align: top; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
.wp-core-ui .date-time-fields .day-fields.clear select, | ||
.wp-core-ui .date-time-fields .time-fields.clear select { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.wp-core-ui .date-time-fields .day-fields.clear select, | |
.wp-core-ui .date-time-fields .time-fields.clear select { | |
.customize-control-date_time select { |
This only needs a class and an element to override .wp-core-ui select { vertical-align: middle; }
in forms.css
. The .customize-control-date_time
class would cover both the date and the time.
@@ -362,11 +362,16 @@ body.trashing #publish-settings { | |||
.date-time-fields .date-input.day, | |||
.date-time-fields .date-input.hour, | |||
.date-time-fields .date-input.minute { | |||
width: 46px; | |||
width: 52px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding another 5 or 6 pixels to each input's width, you could add the tiny-text
class on each of these number fields. The forms.css
stylesheet already removes the right padding to make room for the increment/decrement buttons.
(small-text
might seem more appropriate for the Year field, but it still has padding on small screens and the Customizer's width works with tiny-text
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea to add the class and apply CSS their.
- Used WordPress core's tiny-text class for date/time number inputs instead of custom widths - Provided better handling of increment/decrement buttons through core styles - Ensured consistent styling across different screen sizes - Simplified vertical alignment selector for date/time selects by targeting customize-control-date_time class directly
Hi @sabernhardt and @mukeshpanchal27, |
Trac ticket: #51249
What
Why
How
Testing Instructions
Screenshots
Before patch:
After Patch: