Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer: Fix input field widths and alignment for date-time controls #8178

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Infinite-Null
Copy link

Trac ticket: #51249

What

  • Increased the width of date-time input fields from 46px to 52px
  • Added vertical alignment to select fields in day and time controls

Why

  • The previous width of 46px was causing text to be truncated
  • Select fields were misaligned with neighboring elements, creating visual inconsistency

How

  • Updated width property in date-time input styles to accommodate longer text
  • Added vertical align: top to select elements within day and time field groups

Testing Instructions

  1. Go to Customizer
  2. Navigate to any panel with date-time controls
  3. Verify date/time input fields show complete numbers without truncation
  4. Check that select fields are properly aligned with neighboring inputs

Screenshots

Before patch:

image

After Patch:

image

Copy link

github-actions bot commented Jan 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, mukesh27, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.


.wp-core-ui .date-time-fields .day-fields.clear select,
.wp-core-ui .date-time-fields .time-fields.clear select {
vertical-align: top;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mukeshpanchal27
Copy link
Member

For input type number width it not look good normal state but when hover over the changes make sense.

Screenshot 2025-01-23 at 4 42 19 PM

Comment on lines 368 to 369
.wp-core-ui .date-time-fields .day-fields.clear select,
.wp-core-ui .date-time-fields .time-fields.clear select {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.wp-core-ui .date-time-fields .day-fields.clear select,
.wp-core-ui .date-time-fields .time-fields.clear select {
.customize-control-date_time select {

This only needs a class and an element to override .wp-core-ui select { vertical-align: middle; } in forms.css. The .customize-control-date_time class would cover both the date and the time.

@@ -362,11 +362,16 @@ body.trashing #publish-settings {
.date-time-fields .date-input.day,
.date-time-fields .date-input.hour,
.date-time-fields .date-input.minute {
width: 46px;
width: 52px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding another 5 or 6 pixels to each input's width, you could add the tiny-text class on each of these number fields. The forms.css stylesheet already removes the right padding to make room for the increment/decrement buttons.

(small-text might seem more appropriate for the Year field, but it still has padding on small screens and the Customizer's width works with tiny-text)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to add the class and apply CSS their.

- Used WordPress core's tiny-text class for date/time number inputs instead of custom widths
- Provided better handling of increment/decrement buttons through core styles
- Ensured consistent styling across different screen sizes
- Simplified vertical alignment selector for date/time selects by targeting customize-control-date_time class directly
@Infinite-Null
Copy link
Author

Infinite-Null commented Jan 24, 2025

Hi @sabernhardt and @mukeshpanchal27,
I have made the necessary changes to this PR. Please have a look at it at your convenience.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants