Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have prettier ignore content dirs #58

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Have prettier ignore content dirs #58

merged 1 commit into from
Jun 26, 2019

Conversation

coilysiren
Copy link
Member

@coilysiren coilysiren commented Jun 26, 2019 •
edited
Loading

to fix failed builds from the CMS, like #56

@coilysiren coilysiren requested a review from deweydell June 26, 2019 03:39
@coilysiren coilysiren self-assigned this Jun 26, 2019
@coilysiren
Copy link
Member Author

I merged this into #55 to double check that it works on ci ^^

@deweydell
Copy link
Contributor

Is there anyway to ignore this besides prettierignore? I'm wondering because if choose to add content manually, I still would like prettier to format my code while I'm developing.

deweydell
deweydell approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@deweydell deweydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to merge this now so the speaker PRs build successfully, but would like to revisit a way prettier can work when manually editing content files.

@coilysiren coilysiren merged commit 1a4de71 into production Jun 26, 2019
@coilysiren
Copy link
Member Author

I'll write up an issue about follow-up here!

@coilysiren
Copy link
Member Author

issue => #61

@deweydell deweydell deleted the ignore-content-dirs branch June 26, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deweydell deweydell deweydell approved these changes

Assignees

@coilysiren coilysiren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coilysiren @deweydell