Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.2 Lodestone Updates #57

Merged
merged 3 commits into from
Feb 28, 2020
Merged

5.2 Lodestone Updates #57

merged 3 commits into from
Feb 28, 2020

Conversation

matthewhillier
Copy link
Member

Changes to the parsing to handle the updated lodestone design that has split Class & Job details into a separate page.

@matthewhillier matthewhillier mentioned this pull request Feb 25, 2020
Closed
@matthewhillier matthewhillier requested a review from a team February 25, 2020 05:43
@matthewhillier matthewhillier self-assigned this Feb 25, 2020
@matthewhillier matthewhillier linked an issue Feb 25, 2020 that may be closed by this pull request
Lodestone 5.2 Updates #56
Closed
@Pricetx
Copy link
Member

Pricetx commented Feb 28, 2020

I have run a test with 19,000,000 to 19,100,000. The test largely ran successfully. The only unusual error I saw (other than come connection timeouts) is this:

[2020-02-26 11:24:59,503] [pool-1-thread-29] DEBUG com.ffxivcensus.gatherer.task.GathererTask - Starting evaluation of player ID: 19066937
[2020-02-26 11:24:59,753] [pool-1-thread-3] ERROR com.ffxivcensus.gatherer.task.GathererTask - Index: 0, Size: 0
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0

[2020-02-26 09:59:18,903] [pool-1-thread-28] DEBUG com.ffxivcensus.gatherer.task.GathererTask - Starting evaluation of player ID: 19038375
[2020-02-26 09:59:19,525] [pool-1-thread-21] ERROR com.ffxivcensus.gatherer.task.GathererTask - Index: 0, Size: 0
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0

Anyway, i'm happy to merge this regardless.

Pricetx
Pricetx approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@Pricetx Pricetx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes tested. Approved.

@Pricetx Pricetx merged commit 7c052e8 into master Feb 28, 2020
@matthewhillier matthewhillier mentioned this pull request Feb 28, 2020
Open
@matthewhillier
Copy link
Member Author

Thanks, @Pricetx.
The errors seem to be due to the way Mounts & Minions pages are now loaded when a Character has none. It's handled in the code, but not necessarily gracefully.

Have raised #58 to address it.

@matthewhillier matthewhillier deleted the 56-lodestone_5.2 branch February 28, 2020 12:40
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier
5.2 Lodestone Updates (XIVStats#57)
3733909 
* Added updated lodestone character test resources

* Rewired PlayerBuilder to use new standalone Class / Job page


Fixed some typos

* Fixed unit test failures from changes in character status in Lodestone.


Fixed last unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pricetx Pricetx Pricetx approved these changes

Assignees

@matthewhillier matthewhillier

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lodestone 5.2 Updates
2 participants
@matthewhillier @Pricetx