Migrate HealthChecks.Milvus tests to Testcontainers

Xabaril · Jan 9, 2025 · 91a0868 · 91a0868
1 parent d8d88a0
commit 91a0868
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 43 deletions.
diff --git a/.github/workflows/healthchecks_milvus_ci.yml b/.github/workflows/healthchecks_milvus_ci.yml
@@ -29,43 +29,8 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest  
-    steps:
-      - uses: actions/checkout@v3
-      - name: 'wget'      
-        run: 'wget https://github.com/milvus-io/milvus/releases/download/v2.4.6/milvus-standalone-docker-compose.yml -O docker-compose.yml'      
-      - name: 'compose'
-        run: 'sudo docker compose up -d'		
-      - name: Setup .NET
-        uses: actions/setup-dotnet@v4
-        with:
-          dotnet-version: |
-            8.0.x
-            9.0.x
-      - name: Restore
-        run: |
-          dotnet restore ./src/HealthChecks.Milvus/HealthChecks.Milvus.csproj &&          
-          dotnet restore ./test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj
-      - name: Check formatting
-        run: |
-          dotnet format --no-restore --verify-no-changes --severity warn ./src/HealthChecks.Milvus/HealthChecks.Milvus.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1) &&
-          dotnet format --no-restore --verify-no-changes --severity warn ./test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1)
-      - name: Build
-        run: |
-          dotnet build --no-restore ./src/HealthChecks.Milvus/HealthChecks.Milvus.csproj &&
-          dotnet build --no-restore ./test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj
-      - name: Test
-        run: >
-          dotnet test
-          ./test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj
-          --no-restore
-          --no-build
-          --collect "XPlat Code Coverage"
-          --results-directory .coverage
-          --
-          DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover
-      - name: Upload Coverage
-        uses: codecov/codecov-action@v5
-        with:
-          flags: Milvus
-          directory: .coverage
+    uses: ./.github/workflows/reusable_ci_workflow.yml
+    with:
+      PROJECT_PATH: ./src/HealthChecks.Milvus/HealthChecks.Milvus.csproj
+      TEST_PROJECT_PATH: ./test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj
+      CODECOV_FLAGS: Milvus
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -102,6 +102,7 @@
     <PackageVersion Include="System.Text.Json" Version="8.0.5" />
     <PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
     <PackageVersion Include="System.Threading.Channels" Version="8.0.0" />
+    <PackageVersion Include="Testcontainers.Milvus" Version="$(TestcontainersVersion)" />
     <PackageVersion Include="Testcontainers.PostgreSql" Version="$(TestcontainersVersion)" />
     <PackageVersion Include="TestContainers.MongoDb" Version="$(TestcontainersVersion)" />
     <PackageVersion Include="Testcontainers.MsSql" Version="$(TestcontainersVersion)" />

diff --git a/test/HealthChecks.Milvus.Tests/Functional/MilvusHealthCheckTests.cs b/test/HealthChecks.Milvus.Tests/Functional/MilvusHealthCheckTests.cs
@@ -1,20 +1,23 @@
 using System.Net;
+using Aspire.Milvus.Client.Tests;
 using Milvus.Client;
 
 namespace HealthChecks.Milvus.Tests.Functional;
 
-public class milvus_healthcheck_should
+public class milvus_healthcheck_should(MilvusContainerFixture milvusContainerFixture) : IClassFixture<MilvusContainerFixture>
 {
     [Fact]
     public async Task be_healthy_when_milvus_is_available_using_client_factory()
     {
+        string connectionString = milvusContainerFixture.GetConnectionString();
+
         var webHostBuilder = new WebHostBuilder()
             .ConfigureServices(services =>
             {
                 services
                     .AddHealthChecks()
                     .AddMilvus(
-                        clientFactory: sp => new MilvusClient("localhost"), tags: new string[] { "milvus" });
+                        clientFactory: sp => new MilvusClient(new Uri(connectionString)), tags: new string[] { "milvus" });
             })
             .Configure(app =>
             {
@@ -34,11 +37,13 @@ public async Task be_healthy_when_milvus_is_available_using_client_factory()
     [Fact]
     public async Task be_healthy_when_milvus_is_available_using_singleton()
     {
+        string connectionString = milvusContainerFixture.GetConnectionString();
+
         var webHostBuilder = new WebHostBuilder()
             .ConfigureServices(services =>
             {
                 services
-                    .AddSingleton(new MilvusClient("localhost"))
+                    .AddSingleton(new MilvusClient(new Uri(connectionString)))
                     .AddHealthChecks()
                     .AddMilvus(tags: new string[] { "milvus" });
             })

diff --git a/test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj b/test/HealthChecks.Milvus.Tests/HealthChecks.Milvus.Tests.csproj
@@ -1,5 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+  <ItemGroup>
+    <PackageReference Include="Testcontainers.Milvus" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\..\src\HealthChecks.Milvus\HealthChecks.Milvus.csproj" />
   </ItemGroup>

diff --git a/test/HealthChecks.Milvus.Tests/MilvusContainerFixture.cs b/test/HealthChecks.Milvus.Tests/MilvusContainerFixture.cs
@@ -0,0 +1,38 @@
+using Testcontainers.Milvus;
+
+namespace Aspire.Milvus.Client.Tests;
+
+public sealed class MilvusContainerFixture : IAsyncLifetime
+{
+    public const string Registry = "docker.io";
+
+    public const string Image = "milvusdb/milvus";
+
+
+    public const string Tag = "v2.4.13";
+
+    public MilvusContainer? Container { get; private set; }
+
+    public string GetConnectionString() => Container?.GetEndpoint().AbsoluteUri ??
+        throw new InvalidOperationException("The test container was not initialized.");
+
+    public async Task InitializeAsync() => Container = await CreateContainerAsync();
+
+    public async Task DisposeAsync()
+    {
+        if (Container is not null)
+        {
+            await Container.DisposeAsync();
+        }
+    }
+
+    public static async Task<MilvusContainer> CreateContainerAsync()
+    {
+        var container = new MilvusBuilder()
+            .WithImage($"{Registry}/{Image}:{Tag}")
+            .Build();
+        await container.StartAsync();
+
+        return container;
+    }
+}