-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed invalid api key format raising 500 #1079
Open
pk-zipstack
wants to merge
4
commits into
main
Choose a base branch
from
fix/validate-api-key-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk-zipstack
requested review from
muhammad-ali-e,
chandrasekharan-zipstack,
a team and
gaya3-zipstack
January 20, 2025 11:38
ritwik-g
reviewed
Jan 20, 2025
…raise a UnauthorizedKey() error
for more information, see https://pre-commit.ci
|
Quality Gate passedIssues Measures |
muhammad-ali-e
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chandrasekharan-zipstack
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added API key format validation: Ensures the API key provided in theAuthorization
header is a valid UUID.UpdatedBaseAPIKeyValidator
:Modified thevalidate_api_key
decorator to validate API key format using Python’suuid
module.Enhanced error messages: Returns a400 BadRequest
error when the API key format is invalid.validate_api_key
function inkey_helper.py
to captureValidationError
and raiseUnauthozisedKey()
error.Why
500 Internal Server Error
responses.How
KeyHelper
class:validate_api_key
to catch Django'sValidationError
that occurs during UUID validation and raise anUnauthorizedKey
exception, ensuring consistent error handling for invalid API key formats.Can this PR break any existing features?
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
400 Forbidden
) for invalid formats.Screenshots
Checklist
I have read and understood the Contribution Guidelines.