Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18nMap migration #1094

Merged
merged 4 commits into from
Jan 18, 2025
Merged

I18nMap migration #1094

merged 4 commits into from
Jan 18, 2025

Conversation

tfuent1
Copy link
Contributor

@tfuent1 tfuent1 commented Jan 17, 2025

Contributor checklist


Description

Related issue

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit bfa5a0f
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/678c3942abf58a0008ed20b7

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work here, @tfuent1! 😊 Thanks for a great first contribution that really sets us apart on how we do i18n throughout the project 🥳

Maybe a next issue could be in the i18n-check project? You could consider working on say activist-org/i18n-check#5? Happy to also work on an issue here, but that one jumped to mind :)

@andrewtavis andrewtavis merged commit ebd13a0 into activist-org:main Jan 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants