Skip to content

Commit

Permalink
chore(linting): add workspace lints (#228)
Browse files Browse the repository at this point in the history
Hey, nice work. There's a lot of potential, and the idea of custom
channels with custom run commands is very appealing.

I was looking at the source, but clippy pedantic lints threw a lot of
warnings and I noticed the project did not have a linting profile. I
threw together a profile here, but it does leave a fair amount of
warnings in. Maybe some variation of this, or another linting profile
could be considered to guide future contributors on style decisions.
Cheers

---------

Co-authored-by: Alexandre Pasmantier <[email protected]>
  • Loading branch information
xosxos and alexpasmantier authored Jan 6, 2025
1 parent 76bff30 commit da2396e
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 1 deletion.
22 changes: 22 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,25 @@ lto = "fat"
[profile.deb]
inherits = "release"
debug = false

[lints]
workspace = true

[workspace.lints.clippy]
pedantic = { level = "warn", priority = -1 }

must_use_candidate = "allow"
too_many_lines = "allow"
missing_panics_doc = "allow"
missing_errors_doc = "allow"
module_name_repetitions = "allow"
cast_precision_loss = "allow"
map_unwrap_or = "allow"
return_self_not_must_use = "allow"
uninlined_format_args = "allow"
similar_names = "allow"
float_cmp = "allow"
implicit_hasher = "allow"
wildcard_imports = "allow"
from_iter_instead_of_collect = "allow"

2 changes: 2 additions & 0 deletions crates/television-channels/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ lazy_static = "1.5.0"
toml = "0.8.19"
regex = "1.11.1"

[lints]
workspace = true
2 changes: 2 additions & 0 deletions crates/television-derive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ syn = "2.0.79"
[lib]
proc-macro = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/television-fuzzy/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ rust-version.workspace = true
[dependencies]
nucleo = "0.5.0"
parking_lot = "0.12.3"

[lints]
workspace = true
2 changes: 2 additions & 0 deletions crates/television-previewers/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ simd = ["dep:simdutf8"]
zero-copy = []
default = ["zero-copy", "simd"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/television-screen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ television-channels = { path = "../television-channels", version = "0.0.18" }
television-previewers = { path = "../television-previewers", version = "0.0.18" }
color-eyre = "0.6.3"
syntect = "5.2.0"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/television-utils/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ unicode-width = "0.2.0"

[target.'cfg(windows)'.dependencies]
winapi-util = "0.1.9"

[lints]
workspace = true
2 changes: 1 addition & 1 deletion crates/television-utils/src/input.rs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ impl Input {
None
} else {
let cursor = self.cursor;
self.value = "".into();
self.value = String::new();
self.cursor = 0;
Some(StateChanged {
value: true,
Expand Down

0 comments on commit da2396e

Please sign in to comment.