Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont force .net 9 dependencies for csharp client #4313

Closed
Kalmar99 opened this issue Jan 7, 2025 · 2 comments · Fixed by #4316
Closed

Dont force .net 9 dependencies for csharp client #4313

Kalmar99 opened this issue Jan 7, 2025 · 2 comments · Fixed by #4316

Comments

@Kalmar99
Copy link
Contributor

Kalmar99 commented Jan 7, 2025

Describe the problem

I noticed that in the newer versions of the csharp client you have added a dependency on .NET 9 by relying on Microsoft.Extensions.Logging 9.0.0, unless this version of the package is required for the algolia client to work you should allow a range of versions. Atleast .net 8 should be supported as that is the current LTS version.

Describe the solution

Use version ranges and allow .net 8 (which is the current LTS) up to .net 9

basicly, replace:

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
    <PackageReference Include="System.Text.Json" Version="9.0.0" />
  </ItemGroup>

with

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Logging" Version="[8.0.0, 10.0.0)" />
    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="[8.0.0, 10.0.0)" />
    <PackageReference Include="System.Text.Json" Version="[8.0.0, 10.0.0)" />
  </ItemGroup>

this will allow all versions of the dependencies up to latest minor on .net 9

https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#version-ranges

@morganleroi
Copy link
Contributor

Hey @Kalmar99 !

You're totally right ! I will make the change ASAP.

@Kalmar99
Copy link
Contributor Author

Kalmar99 commented Jan 7, 2025

Great, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants