Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp): update deps to allow a range #4316

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

morganleroi
Copy link
Contributor

🧭 What and Why

closes #4313

Changes included:

  • Allows deps to be >= 8 to < 10

@morganleroi morganleroi requested a review from a team as a code owner January 7, 2025 12:46
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 7, 2025

✔️ Code generated!

Name Link
🪓 Triggered by d3f89452d1529b0c485c194547b7696d983d1db1
🍃 Generated commit cf93dc49f8fc78db6bb2be87dc51375f547e6b92
🌲 Generated branch generated/fix/allow-microsoft-deps-from8to9
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
csharp 1372

@shortcuts
Copy link
Member

@shortcuts
Copy link
Member

btw it could be great to have https://github.com/algolia/api-clients-automation/blob/main/config/clients.config.json#L264-L269 to test multiple versions

@morganleroi morganleroi enabled auto-merge (squash) January 7, 2025 13:14
@morganleroi morganleroi self-assigned this Jan 7, 2025
@morganleroi morganleroi merged commit 9e05bf2 into main Jan 7, 2025
12 checks passed
@morganleroi morganleroi deleted the fix/allow-microsoft-deps-from8to9 branch January 7, 2025 13:24
algolia-bot added a commit that referenced this pull request Jan 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont force .net 9 dependencies for csharp client
3 participants