fix(dart): use qs_dart for HTTP query encoding in DioRequester #3294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Use qs_dart to encode the HTTP query in DioRequester.
Why? I think that using a naive approach like
api-clients-automation/clients/algoliasearch-client-dart/packages/client_core/lib/src/transport/dio/dio_requester.dart
Line 104 in 0052b1f
is not exhaustive enough.
Changes included:
DioRequester.requestUri
methodFull disclosure: I am the author of qs_dart which is itself is a port of qs.
qs_dart has extensive tests and has been used in Chopper since v7.4.0.