fix(kotlin): macos compatible helpers and build on CI #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
force-pushed
the
feat/kotlin-build-macos
branch
from
7f4f789 to
acfc9fb
Compare
✔️ Code generated!
|
shortcuts
changed the title
Fluf22
reviewed
Jul 1, 2024
| if: | | ||
| always() && | ||
| (needs.swift_cts_macos.result == 'success' || needs.swift_cts_macos.result == 'skipped') && |
There was a problem hiding this comment.
Yup it should already be validate by the next clause I think
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jul 1, 2024
algolia/api-clients-automation#3297 Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2535
Changes included:
build fail on macos https://github.com/algolia/algoliasearch-client-kotlin/actions/runs/9699224976/job/26767673731 but looks good on ubuntu
this is because we use non native features in some helpers, now our CI builds both version so we don't make the same mistake again