fix(scripts): skip failure report for ruby #3303
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. |
| if (!success) { | ||
|
|
||
| // Ruby action is flaky for now but the release succeed | ||
| if (!success && ciRun.language !== 'ruby') { |
There was a problem hiding this comment.
I think the fix should be in clients/algoliasearch-client-ruby/.github/workflows/release.yml directly, with a small continue-on-error: true, that way if something else goes wrong we can still see it
There was a problem hiding this comment.
wouldn't it behave exactly like this? the difference here is that on the Ruby repo, it will still fail
There was a problem hiding this comment.
yeah but its wrong on the ruby repo, the release is working, it should also be green there
There was a problem hiding this comment.
yes but it doesn't depend on us, the action really fails :/ IMO we should find an other GHA but I don't have the time right now and don't want to block the docs
There was a problem hiding this comment.
the action doesn't fail since its released, its just the wait after that fails.
When a users looks at the ruby repo to see what is released it should be green IMO
There was a problem hiding this comment.
XD just realized it's a single simple file we can patch it maybe https://github.com/rubygems/release-gem/blob/v1/action.yml, would've been faster than this conversation
There was a problem hiding this comment.
await-release:
description: "Whether to poll for the release to be available on RubyGems.org"
required: false
default: "true"
There was a problem hiding this comment.
ahah nice they know its flaky
There was a problem hiding this comment.
do we shake hands now? a879bd0
This reverts commit 1bc883a.
|
🤝 nice |
algolia/api-clients-automation#3303 Co-authored-by: Clément Vannicatte <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2494
Changes included:
le ruby release succeed but the ruby release action then lookup on the registry to find the version and somehow fails (but it worked!)
since the GA release approach and we need wait release to succeed in order to spread new versions to the docs, we can skip ruby for now