Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup before pushing to docs #3332

Merged
merged 1 commit into from
Jul 8, 2024
Merged

chore: cleanup before pushing to docs #3332

merged 1 commit into from
Jul 8, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

delete files before pushing to algolia doc, see https://github.com/algolia/doc/pull/9156

@shortcuts shortcuts self-assigned this Jul 8, 2024
@shortcuts shortcuts requested a review from a team as a code owner July 8, 2024 14:38
@shortcuts shortcuts requested review from morganleroi and millotp July 8, 2024 14:38
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 8, 2024 •
edited
Loading

No code generated

If you believe code should've been generated, please, report the issue.

@shortcuts shortcuts enabled auto-merge (squash) July 8, 2024 14:40
millotp
millotp reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks a big dangerous, nothing indicates that this folder has generated files, anyone can add a file there.
should we rename the folder to app_data/api/specs/generated/ and then its okay to rimraf ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

🚀 Deployed on https://668bff2957dbbf4ba6c61303--api-clients-automation.netlify.app

millotp
millotp approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking for now

@shortcuts shortcuts merged commit aad2712 into main Jul 8, 2024
20 checks passed
@shortcuts shortcuts deleted the chore/scripts-push-docs branch July 8, 2024 17:24
@algolia-bot algolia-bot mentioned this pull request Jul 9, 2024
Closed
@shortcuts shortcuts mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp