fix(cts): split requests and e2e tests #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
|
shortcuts
reviewed
Jul 9, 2024
yes good idea, I will make all the changes to the CI in the next PR, this is just to split them and generate all the files |
shortcuts
previously approved these changes
Jul 9, 2024
|
|
||
| // We only store tests of clients that ran during this job, the rest stay as is | ||
| let testsToStore = matrix[language].toRun | ||
| .map((client) => { | ||
| const clientName = createClientName(client, language); | ||
| const extension = getTestExtension(language); | ||
|
|
||
| return `${testsOutputBase}/client/${clientName}${extension} ${testsOutputBase}/requests/${clientName}${extension}`; | ||
| return `${testsOutputBase}/client/${clientName}${extension} ${testsOutputBase}/requests/${clientName}${extension} ${testsOutputBase}/requests_e2e/${clientName}${extension}`; |
There was a problem hiding this comment.
maybe names should just be unit and e2e instead or requests
There was a problem hiding this comment.
thats a big change, its the good time to do it, but I feel like both client and request tests are unit tests, maybe I can just rename request_e2e to responses or e2e
There was a problem hiding this comment.
it was more to fit the usual naming of tests with unit, integration and e2e, but indeed both are unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-2573
Split e2e to be able to retry them, or exclude them when running the test suite offline.