Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): update shopify feature flags #3380

Merged
merged 6 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ jobs:
type: minimal
language: swift

- run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }}
- run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }} -v

- name: Set output
id: setoutput
Expand Down
2 changes: 1 addition & 1 deletion scripts/cts/runCts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ async function runCtsOne(
break;
case 'swift':
await run(
`swift test -Xswiftc -suppress-warnings -q --parallel ${filter((f) => `--filter ${f}.*`)}`,
`swift test -Xswiftc -suppress-warnings -v --parallel ${filter((f) => `--filter ${f}.*`)}`,
{
cwd,
language,
Expand Down
50 changes: 4 additions & 46 deletions specs/ingestion/common/schemas/source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -457,52 +457,10 @@ SourceUpdateShopify:
type: object
additionalProperties: false
properties:
collectionIDIndexing:
type: boolean
default: false
description: |
Whether to index collection IDs.

If your store has `has_collection_search_page` set to true,
collection IDs will be indexed even if `collectionIDIndexing` is false.
increaseProductCollectionLimit:
type: boolean
default: false
description: |
Whether to increase the number of indexed collections per product.
If true, Algolia indexes 200 collections per product.
If false, 100 collections per product are indexed.
defaultPriceRatioAsOne:
type: boolean
default: true
description: |
Whether to set the default price ratio to 1 if no sale price is present.

The price ratio is determined by the ratio: `sale_price` / `regular_price`.
If no sale price is present, the price ratio would be 0.
If `defaultPriceRatioAsOne` is true, the price ratio is indexed as 1 instead.
excludeOOSVariantsForPriceAtTRS:
type: boolean
default: true
description: |
Whether to exclude out-of-stock variants when determining the `max_variant_price` and `min_variant_price` attributes.
includeVariantsInventory:
type: boolean
default: true
description: |
Whether to include an inventory with every variant for every product record.
hasCollectionSearchPage:
type: boolean
default: false
description: |
Whether to include collection IDs and handles in the product records.
productNamedTags:
type: boolean
default: false
description: |
Whether to convert tags on products to named tags.

To learn more, see [Named tags](https://www.algolia.com/doc/integration/shopify/sending-and-managing-data/named-tags).
featureFlags:
type: object
description: Feature flags for the Shopify source.
additionalProperties: true

SourceShopify:
allOf:
Expand Down
Loading