Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): required prop for dictionaryEntry #3449

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix(specs): required prop for dictionaryEntry #3449

merged 3 commits into from
Jul 30, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jul 30, 2024

🧭 What and Why

When deleting dictionary entries with the BatchDictionaryEntries operation, the request body must only contain objectID props for each entry to delete.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 30, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 508a83bb35264f8681e937aebe4fa247b6a4fcc5
🍃 Generated commit ec6bf96b53c24e48fbb85eb8b2f2b4087fe565cd
🌲 Generated branch generated/fix/dictionary
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1385
javascript 1366
csharp 1100
java 935
ruby 871
swift 740
python 713
kotlin 489
go 464

@kai687 kai687 marked this pull request as ready for review July 30, 2024 12:30
@kai687 kai687 requested a review from a team as a code owner July 30, 2024 12:30
@kai687 kai687 requested review from Fluf22 and millotp July 30, 2024 12:30
Copy link

github-actions bot commented Jul 30, 2024

@millotp millotp enabled auto-merge (squash) July 30, 2024 13:17
@millotp
Copy link
Collaborator

millotp commented Jul 30, 2024

Good catch !

@millotp millotp merged commit 9a2e7a8 into main Jul 30, 2024
21 checks passed
@millotp millotp deleted the fix/dictionary branch July 30, 2024 13:31
algolia-bot added a commit that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants