Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): recommend _score is optional #3967

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3041

Changes included:

closes #3940 algolia/algoliasearch-client-javascript#1560

there is a chance that this property is not present in the response (confirmed by @raed667 and @benamib)

@shortcuts shortcuts self-assigned this Oct 14, 2024
@shortcuts shortcuts requested a review from a team as a code owner October 14, 2024 12:15
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 14, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 8f65557be58959a36a94f32d3921857ce26b0584
🍃 Generated commit 0cbb21f715af1c76fc55e0742c09303e2edf7199
🌲 Generated branch generated/fix/specs-score-optional
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1666
go 1658
php 1460
csharp 1344
java 1098
python 1017
ruby 841
swift 756

raed667
raed667 previously approved these changes Oct 14, 2024
Copy link
Contributor

@raed667 raed667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM 🥇

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go !

@shortcuts shortcuts merged commit 6c04971 into main Oct 14, 2024
27 checks passed
@shortcuts shortcuts deleted the fix/specs-score-optional branch October 14, 2024 12:41
algolia-bot added a commit that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Score field is missing in the Recommendation API response
5 participants