Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): update sample_datasets fetch url #4364

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

LorrisSaintGenez
Copy link
Contributor

@LorrisSaintGenez LorrisSaintGenez commented Jan 16, 2025

🧭 What and Why

🎟 JIRA Ticket: [SELFSER-969](https://algolia.atlassian.net/browse/SELFSER-969?atlOrigin=eyJpIjoiMTJiNDg3MjhiOTg3NDhjNmExMTY3YzkwYTFkN2Y0MzYiLCJwIjoiaiJ9)

We're updating the dashboard sample_datasets url on this PR.
We need to waiting until it's merged before merging this current PR

Changes included:

  • Update sample_datasets URL on all api clients

⚠️ Dependencies

https://github.com/algolia/AlgoliaWeb/pull/23286

@LorrisSaintGenez LorrisSaintGenez self-assigned this Jan 16, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 16, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 89cc8b24d55216384187e32866f1ba870c45fea6
🍃 Generated commit bdb5517da5e8939cc3f854f7b7ebffdc2a46c494
🌲 Generated branch generated/feat/selfser-969
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1655
go 1636
php 1511
csharp 1298
java 1119
python 1058
ruby 866
swift 764

@LorrisSaintGenez LorrisSaintGenez changed the title feat(datasets): update sample_datasets fetch url feat(scripts): update sample_datasets fetch url Jan 16, 2025
@LorrisSaintGenez LorrisSaintGenez marked this pull request as ready for review January 22, 2025 21:05
@LorrisSaintGenez LorrisSaintGenez requested a review from a team as a code owner January 22, 2025 21:05
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I've removed the generated files from your pr, the ci will push it

let me know when I can merge :D

@LorrisSaintGenez
Copy link
Contributor Author

Oopsi, thank you @shortcuts !

It's safe to merge it now :shipit:

@millotp millotp merged commit 62257d3 into main Jan 23, 2025
28 checks passed
@millotp millotp deleted the feat/selfser-969 branch January 23, 2025 08:31
algolia-bot added a commit that referenced this pull request Jan 23, 2025
…skip ci]

Co-authored-by: Lorris Saint-Genez <[email protected]>
Co-authored-by: shortcuts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants