Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: add missing snippets to docs #4391

Merged
merged 15 commits into from
Jan 23, 2025
Merged

guides: add missing snippets to docs #4391

merged 15 commits into from
Jan 23, 2025

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 22, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3429

Changes included:

add some missing snippets found in https://github.com/algolia/doc/pull/9682, more to come I guess but this unblocks me for https://github.com/algolia/doc/pull/9682

@shortcuts shortcuts self-assigned this Jan 22, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 22, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 024a5b77d7fddec63448d3468593e46886cfcd8c
🍃 Generated commit f0ced5ed69961fcd24c5a4c5dcdab28bf0fafd84
🌲 Generated branch generated/chore/guides
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1643
javascript 1576
php 1460
csharp 1414
java 1156
python 1085
ruby 845
swift 738

@shortcuts shortcuts changed the title chore: more guides guides: add missing snippets to docs Jan 22, 2025
@shortcuts shortcuts marked this pull request as ready for review January 23, 2025 11:03
@shortcuts shortcuts requested a review from a team as a code owner January 23, 2025 11:03
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should reorder the CTS to make sure the one we want to display in the doc is at the top

scripts/formatter.ts Outdated Show resolved Hide resolved
Fluf22
Fluf22 previously approved these changes Jan 23, 2025
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@shortcuts shortcuts requested review from millotp and Fluf22 January 23, 2025 16:00
@shortcuts shortcuts merged commit ad43bfb into main Jan 23, 2025
28 checks passed
@shortcuts shortcuts deleted the chore/guides branch January 23, 2025 16:08
algolia-bot added a commit that referenced this pull request Jan 23, 2025
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 23, 2025
algolia/api-clients-automation#4391

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants