fix(specs): add type: object to 3 schemas #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit is better than implicit, so this commit adds `type: object` to 3 schemas standardEntries, userData, and source.
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
|
algolia-bot
added a commit
that referenced
this pull request
Jan 23, 2025
Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jan 23, 2025
algolia/api-clients-automation#4392 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
I found some schemas without specified
typeproperty.3 of them are
type: objectwhich is probably implied since they had theproperties:field.1 schema didn't have a type defined which made it
type: anybut it should be a string.This helps with me rendering method parameters etc.
🎟 JIRA Ticket:
Changes included:
Search API
Added
type: objectto:standardEntriesuserDatasource(was implied before since all of them had
properties)Recommend API
Added
type: stringto:facetName(was unspecified before and rendered in the docs as
type: any).