Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: update the snippets according to the doc review #4412

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 29, 2025

🧭 What and Why

This updates the snippets according to @gazconroy review in https://github.com/algolia/doc/pull/9688

@millotp millotp self-assigned this Jan 29, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 29, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 2cf923df4519f011466accf353a7042bd26568c9
🍃 Generated commit 85fdc324cc0e8444f42336da7d6361eed8b75a36
🌲 Generated branch generated/fix/gary-review
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1624
javascript 1574
php 1486
csharp 1407
java 1106
python 1074
ruby 784
swift 769

@millotp millotp marked this pull request as ready for review January 29, 2025 13:27
@millotp millotp requested a review from a team as a code owner January 29, 2025 13:27
@millotp millotp requested review from morganleroi and Fluf22 January 29, 2025 13:27
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@millotp millotp merged commit 6ecf7d3 into main Jan 29, 2025
28 checks passed
@millotp millotp deleted the fix/gary-review branch January 29, 2025 13:40
algolia-bot added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants