Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(router): add guide on using postrenderhooks #773

Conversation

santoshyadavdev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #669

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 9c2db26
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/656e2e06a4f5bd00072606bf
😎 Deploy Preview https://deploy-preview-773--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 9c2db26
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/656e2e06c3821f0008bf098d
😎 Deploy Preview https://deploy-preview-773--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 9c2db26
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/656e2e067a337d0008bd4954
😎 Deploy Preview https://deploy-preview-773--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ajitzero ajitzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this PR while looking up the docs for postRenderingHooks! Thanks for this, I will try this tonight.

I don't know much about the actual code, but noticed a few typos and grammar issues while going through this.

@brandonroberts
Copy link
Member

Good feedback @ajitzero, thanks

@santoshyadavdev
Copy link
Contributor Author

Thanks @ajitzero updated the PR

@brandonroberts brandonroberts merged commit 07452e0 into analogjs:main Dec 4, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add guide on using post render hooks with static site generation
3 participants