homework02 К24 Юров Кирилл 1.3 #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Если к 28 января сделаете хорошее ревью работы в этом пул-реквесте (#269), вам хватит баллов, чтобы закрыться |
|
Ревью зачтено |
yunoori
reviewed
Jan 28, 2025
| path = pathlib.Path(path) | ||
| with path.open() as f: | ||
| puzzle = f.read() | ||
| return create_grid(puzzle) | ||
|
|
||
|
|
||
| def create_grid(puzzle: str) -> tp.List[tp.List[str]]: | ||
| """Creates grid for puzzle""" | ||
| digits = [c for c in puzzle if c in "123456789."] |
There was a problem hiding this comment.
Можно упростить и объединить две строки (20 и 21) в grid = [int(char) for char in puzzle if char in '123456789.']
| for j in range(0, 9, 3): | ||
| arr = get_block(solution, (i, j)) | ||
| used = [0] * 10 | ||
| for z, val in enumerate(arr): |
There was a problem hiding this comment.
Немного усложнил перебор массива с лишним enumerate, тк z не использовалась
| ch_pos = dot_list[replace_pos] | ||
| empty_grid[ch_pos[0]][ch_pos[1]] = cor_grid[ch_pos[0]][ch_pos[1]] | ||
| dot_list.pop(replace_pos) | ||
| return empty_grid |
There was a problem hiding this comment.
мне кажется, что данный код не генерирует случайный массив, а только выбирает случайные точки из этого массива и, допустим, на n>=81 ответ будет один и тот же и массив не будет отличаться
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.