fix(material/button): increase touch target for icon buttons #30380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
crisbeto
reviewed
Jan 24, 2025
Updates Angular Components Button styles for icon buttons to add pseudo class styles to increase the icon buttons' target size. Fixes b/378903269
essjay05
force-pushed
the
increase-icon-button-touch-target
branch
from
098a039 to
4051dd0
Compare
Updates previous fix to increasing Angular Components Icon Button by removing the pseudo class styles and targeting the correct class .mat-mdc-button-touch-target instead. Also, removes any redundant styles simplifies the necessary styles to increase the touch target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Button styles for icon buttons to add pseudo class styles to increase the icon buttons' target size.
Before screenshot
Updated after screenshot with refactor:
After screenshot
Fixes b/378903269