-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layout ggplots in a table #139
Draft
siddhesh195
wants to merge
73
commits into
master
Choose a base branch
from
html-plot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
e5a6803
Test to check for title of 3 plots
siddhesh195 d11bd6f
added test to verify number of tables , their dimensions and number o…
siddhesh195 ae7bd35
ramping up on animint.js
siddhesh195 e516b9a
add all plots in single row
siddhesh195 6ba7e6a
used element variable
siddhesh195 89c1e2f
Update .gitignore
siddhesh195 e53e7d9
put all plots in one column
siddhesh195 0ae75de
add 2 plots per row and then make a new row
siddhesh195 adf012b
table with 3 plots per row or user defined layout
siddhesh195 a2b8c0a
test for putting plots in specific location of outer table
siddhesh195 45bbcf7
check if svg element exists in a particular location of outer table
siddhesh195 4951b0b
error message if user forgets to add either row or column
siddhesh195 96c5a45
made function to check svg
siddhesh195 0a78f92
put plots with fixed locations first, then put all other plots
siddhesh195 a692b3d
changed scope of implicitly global variables
siddhesh195 95cd30f
Give error message if only row or col is added in theme
siddhesh195 6999ac7
theme_animint now accepts dimensions and not theme
siddhesh195 91d0abb
removed debugging line
siddhesh195 5b05e8a
removed comments
siddhesh195 2e1a5f5
reverted to original style and indentation
siddhesh195 9af1fe8
made border transparent
siddhesh195 a1735d2
added var as prefix to make it local
siddhesh195 8698e18
plots save span
siddhesh195 fbd9541
Merge branch 'master' into html-plot
siddhesh195 d4c90aa
rowspan is applied
siddhesh195 80943e6
colspan can now be applied
siddhesh195 4ac2937
refactoring
siddhesh195 4a4d8ea
corrected response.plots[p_name].row toresponse.plots[p_name].positio…
siddhesh195 7fa9efe
throw error if user is incosistent is passing row and col
siddhesh195 3499fea
removed check_svg function
siddhesh195 905feb3
refactoring
siddhesh195 0287024
corrected code to properly traverse the outer table
siddhesh195 00040cc
Merge branch 'master' into html-plot
siddhesh195 e46f73c
Test to check for title of 3 plots
siddhesh195 3cefb99
added test to verify number of tables , their dimensions and number o…
siddhesh195 efcd2c5
ramping up on animint.js
siddhesh195 071eeb5
add all plots in single row
siddhesh195 744a638
used element variable
siddhesh195 0fe67a8
Update .gitignore
siddhesh195 57d530b
put all plots in one column
siddhesh195 c1fbe30
add 2 plots per row and then make a new row
siddhesh195 8da6e6c
table with 3 plots per row or user defined layout
siddhesh195 dbbfcc7
test for putting plots in specific location of outer table
siddhesh195 e671218
check if svg element exists in a particular location of outer table
siddhesh195 42eaf91
error message if user forgets to add either row or column
siddhesh195 3a3141b
made function to check svg
siddhesh195 cb45b68
put plots with fixed locations first, then put all other plots
siddhesh195 06d5c10
changed scope of implicitly global variables
siddhesh195 0368b85
Give error message if only row or col is added in theme
siddhesh195 28f5cac
theme_animint now accepts dimensions and not theme
siddhesh195 c5e4c8c
removed debugging line
siddhesh195 aa07dd9
removed comments
siddhesh195 7b31296
reverted to original style and indentation
siddhesh195 70d550d
made border transparent
siddhesh195 d3e15b3
added var as prefix to make it local
siddhesh195 731041f
plots save span
siddhesh195 06d02c8
rowspan is applied
siddhesh195 1eff5de
colspan can now be applied
siddhesh195 0ecc99f
refactoring
siddhesh195 54fcb77
corrected response.plots[p_name].row toresponse.plots[p_name].positio…
siddhesh195 3a11c39
throw error if user is incosistent is passing row and col
siddhesh195 a21e13b
removed check_svg function
siddhesh195 841c4ff
refactoring
siddhesh195 87ecfda
corrected code to properly traverse the outer table
siddhesh195 47544aa
Merge branch 'html-plot' of https://github.com/animint/animint2 into …
siddhesh195 c66cdb0
removed blank lines
siddhesh195 d9e0310
combined getRowAndColumn and getRowspanAndColumnspan functions
siddhesh195 446e549
reverting changes for debugging
siddhesh195 ff96811
merged functions into attribute function
siddhesh195 9624583
code for handling rowspan
siddhesh195 3996202
removed unnecessary lines and added test
siddhesh195 700f1d9
refactored code, added test
siddhesh195 4580713
Merge branch 'master' into html-plot
siddhesh195 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,4 @@ | |
*ANIMINT_TEST_FOO | ||
*pids.txt | ||
*~ | ||
test-renderer1-knit-print.R |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
sendKey <- function(key, code, keyCode) { | ||
remDr$Input$dispatchKeyEvent(type = "keyDown", key = key, code = code, windowsVirtualKeyCode = keyCode, nativeVirtualKeyCode = keyCode) | ||
remDr$Input$dispatchKeyEvent(type = "keyUp", key = key, code = code, windowsVirtualKeyCode = keyCode, nativeVirtualKeyCode = keyCode) | ||
} | ||
|
||
clickID <- function(...){ | ||
v <- c(...) | ||
stopifnot(length(v) == 1) | ||
runtime_evaluate(script=sprintf("document.getElementById('%s').dispatchEvent(new CustomEvent('click'))", as.character(v))) | ||
} | ||
|
||
runtime_evaluate <- function(script=NULL,return.value=FALSE){ | ||
eval.result<- remDr$Runtime$evaluate(script,returnByValue = TRUE) | ||
if (return.value){ | ||
eval.result$result$value | ||
}else{ | ||
eval.result | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't these functions redundant with other functions? why do they need to be in a separate file? how are they different? please either delete, move, or add a comment here to explain why they need to stay here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look into that. I don't remember the exact reason I thought of to make a new file, maybe I missed to notice that a separate file was not necessary.