-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(empty-cards): Add 'keep notes' checkbox #17815
base: main
Are you sure you want to change the base?
Conversation
93b197d
to
c0cf606
Compare
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/EmptyCardsDialog.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question use of Bundle as message passing mechanism in face of possibly unbounded data to pass, otherwise LGTM
672f455
to
6c3c5c5
Compare
6c3c5c5
to
5f5e291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a note for the error state when searching the cards.
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/EmptyCardsDialogFragment.kt
Outdated
Show resolved
Hide resolved
fix(empty-cards): window title casing improvement(empty-cards): use Material Dialog TR.emptyCardsPreserveNotesCheckbox() https://github.com/ankitects/anki/blob/39e293b27d36318e00131fd10144755eec8d1922/qt/aqt/emptycards.py#L98-L109 A view is used as dialogs don't support both Checkboxes and a 'message' Co-authored-by: lukstbit <[email protected]>
c166317
to
21d05c3
Compare
Purpose / Description
Fixes
Approach
How Has This Been Tested?
Unit tested, somewhat
Learning (optional, can help others)
Checklist