Skip to content

Commit

Permalink
exported symbols: avoid wildcard
Browse files Browse the repository at this point in the history
* export specific symbols instead of destroy* wildcard
* order symbols alphabetically

Thanks @agx for suggestions.
  • Loading branch information
anoop142 committed Nov 5, 2023
1 parent c98f431 commit 92c3c65
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions govarnam.syms
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
{
global:
destroySchemeDetailsArray;
destroySuggestionsArray;
destroySymbolArray;
destroyTransliterationResult;
makeSymbol;
varnam_*;
varray_*;
vm_*;
makeSymbol;
destroy*;
local:
*;
};
Expand Down

1 comment on commit 92c3c65

@agx
Copy link

@agx agx commented on 92c3c65 Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. That looks good to me.

I wonder if we shouldn't namespace ((prefix with varnam_ ) those (maybe as a follow up) as we can't ever drop symbols again without bumping the soname too as it breaks distribution packaging

EDIT: I've filed varnamproject#46 to track this.

Please sign in to comment.