Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support update peerDependencies #69

Closed
wants to merge 2 commits into from

Conversation

LarchLiu
Copy link

@LarchLiu LarchLiu commented Jul 5, 2023

Description

I am facing the same issue as mentioned in #46, so I added it.

Linked Issues

#46

Additional context

Maybe some additional param should be added? The current way of handling this is the same as optionalDependencies.

@antfu
Copy link
Member

antfu commented Jul 11, 2023

I think it was not added intentionally, as peerDeps are not really your dependencies but rather a specification of the range of deps the library supports. IMO, peerDeps should be as loose as possible to support a wider range of usages, and should not need to be upgraded frequently.

@LarchLiu LarchLiu closed this Jul 11, 2023
@Mister-Hope
Copy link

Mister-Hope commented Dec 12, 2024

I think it was not added intentionally, as peerDeps are not really your dependencies but rather a specification of the range of deps the library supports. IMO, peerDeps should be as loose as possible to support a wider range of usages, and should not need to be upgraded frequently.

I agree the point, and this PR is unacceptable as it's including as the default behavior. but there are situations where peer are expected to bump: during the next major development.

For example, when you are trying to develop a new major of a eslint-plugin for eslint9 when it's staring alpha stage, the peer might be expected to be "locked" to a single version of alpha|beta|rc dep as there are possible breaking changes in the next version for eslint.

npm-check-updates has such a option for the peer bump and it needs opt-in, so I think adding such an option is meaningful.

In my usage, I am trying to bump vuepress/ecosystem with vuepress/core and we are in rc stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants