Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New csv files that use different field types for expanding DataFusion csv reading tests #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jan 20, 2023

No description provided.

@kou kou changed the title New csv files that use different field types for expanding DataFusion… New csv files that use different field types for expanding DataFusion csv reading tests Jan 21, 2023
@kou
Copy link
Member

kou commented Jan 21, 2023

Could you also add README that describes the data content like https://github.com/apache/arrow-testing/blob/master/data/parquet/README.md ?

@jdye64
Copy link
Contributor Author

jdye64 commented Jan 21, 2023

@kou Yes, Sorry I should have done that the first time. I'm not near a computer right now but will do that tomorrow and make another commit.

@andygrove andygrove self-requested a review January 21, 2023 15:17
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 21, 2023

@kou let me know what you think about the README changes. Wasn't exactly sure what to put in there?

@kou
Copy link
Member

kou commented Jan 21, 2023

Thanks. I think that the added description is enough. But we need to check a license for data copied from others to compliant its license.

The commit message of plotly/datasets@79f2104 said "added tips from RStudio".

@nealrichardson Do you know the license of the tips dataset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants