[CALCITE-6771] Convert Type from FLOAT to DOUBLE in PrestoDialect #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobiGo
approved these changes
Jan 9, 2025
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
mihaibudiu
added
the
LGTM-will-merge-soon
xiaochen-zhou
force-pushed
the
presto_float_double
branch
from
3b876a7 to
8086321
Compare
caicancai
reviewed
Jan 9, 2025
caicancai
approved these changes
Jan 9, 2025
xiaochen-zhou
force-pushed
the
presto_float_double
branch
2 times, most recently
from
b367390 to
fba35ad
Compare
NobiGo
requested changes
Jan 9, 2025
| @@ -9093,6 +9093,20 @@ private void checkLiteral2(String expression, String expected) { | |||
| sql(query).withOracle().ok(oracle); | |||
| } | |||
|
|
|||
| /** Test case for | |||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-6771">[CALCITE-6771] | |||
| * Convert Type from FLOAT to DOUBLE in PrestoDialect </a>. */ | |||
There was a problem hiding this comment.
Minor: No space in PrestoDialect and </a>;
There was a problem hiding this comment.
Minor: No space in
PrestoDialectand</a>;
Done.
xiaochen-zhou
force-pushed
the
presto_float_double
branch
from
969cecb to
09b6d31
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FLOAT type is not supported in Presto
According to the documentation: https://prestodb.io/docs/current/language/types.html#real
Using CAST(xxxx AS FLOAT) will result in an error:
It should be converted to the DOUBLE type instead.