Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COLLECTIONS-867: Switched iterator filters to use java.util.function.Predicate #562

Closed

Conversation

Claudenw
Copy link
Contributor

Replaced usage of commons-collections Predicate with java.util.function.Predicate in iterator filtering.

@garydgregory
Copy link
Member

garydgregory commented Oct 18, 2024

Hi @Claudenw

-1: Please see the email thread from way back in July: https://lists.apache.org/thread/44dr03zs4zr92yypgxgsq84273n5g211

Yep, it's a pain, but Collections predates Java 8 and uses custom functional interfaces.

This would be for the next major release so we don't break all existing call sites by breaking binary compatibility.

@Claudenw
Copy link
Contributor Author

Gary's objection makes sense. Closing this without merging.

@Claudenw Claudenw closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants