Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [opt](docker)Replace healthy container with --wait #47357 #47420

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from
Open

branch-3.0: [opt](docker)Replace healthy container with --wait #47357 #47420

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47357

@Thearas
[opt](docker)Replace healthy container with --wait (#47357)
dd8dbd5 
### What problem does this PR solve?

Problem Summary:

Docker compose `--wait` does the same things as those `hello-world`
containers: Wait main service to be health. So just replace the
`hello-world` containers to `--wait`.
@github-actions github-actions bot requested a review from dataroaring as a code owner January 24, 2025 09:20
@zgxme
Copy link
Contributor

zgxme commented Jan 24, 2025

run buildall

zgxme
zgxme approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@zgxme zgxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgxme zgxme zgxme approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zgxme @Thearas