Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Replace ImplicitConversions with CollectionConverters #18412

Merged
merged 1 commit into from
Jan 9, 2025
Merged

MINOR: Replace ImplicitConversions with CollectionConverters #18412

merged 1 commit into from
Jan 9, 2025

Conversation

frankvicky
Copy link
Contributor

ImplicitConversion has been deprecated since Scala 2.13, we should replace it with CollectionConverters
Reference: https://www.scala-lang.org/api/2.13.9/scala/collection/convert/ImplicitConversions$.html

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Jan 7, 2025
mimaison
mimaison approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@mimaison mimaison merged commit 6fa5537 into apache:trunk Jan 9, 2025
9 of 10 checks passed
@github-actions github-actions bot removed the triage PRs from the community label Jan 10, 2025
askew pushed a commit to askew/kafka that referenced this pull request Jan 23, 2025
@frankvicky @askew
MINOR: Replace ImplicitConversions with CollectionConverters (apache#…
be388e4 
…18412)


Reviewers: Mickael Maison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison mimaison approved these changes

Assignees
No one assigned
Labels
ci-approved core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankvicky @mimaison @FrankYang0529