KAFKA-18399 Remove ZooKeeper from KafkaApis (1/N): LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA
#18417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
m1a2st
commented
Jan 7, 2025
m1a2st
changed the title
m1a2st
changed the title
LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA (1/N)
chia7712
reviewed
Jan 9, 2025
| @@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.FETCH => handleFetchRequest(request) | |||
| case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request) | |||
| case ApiKeys.METADATA => handleTopicMetadataRequest(request) | |||
| case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request) | |||
There was a problem hiding this comment.
Could you please use KafkaApis.shouldNeverReceive to keep the same error message?
| @@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.FETCH => handleFetchRequest(request) | |||
| case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request) | |||
| case ApiKeys.METADATA => handleTopicMetadataRequest(request) | |||
| case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request) | |||
| case ApiKeys.STOP_REPLICA => handleStopReplicaRequest(request) | |||
| @@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.FETCH => handleFetchRequest(request) | |||
| case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request) | |||
| case ApiKeys.METADATA => handleTopicMetadataRequest(request) | |||
| case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request) | |||
| case ApiKeys.STOP_REPLICA => handleStopReplicaRequest(request) | |||
| case ApiKeys.UPDATE_METADATA => handleUpdateMetadataRequest(request, requestLocal) | |||
| @@ -3034,99 +3032,7 @@ class KafkaApisTest extends Logging { | |||
| val markersResponse = capturedResponse.getValue | |||
| assertEquals(2, markersResponse.errorsByProducerId.size()) | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Could you please add unit test to ensure those removed RPC can see correct error?
|
Thanks for @chia7712 review, In |
|
Yes, you are right. Removing the handler is fine |
chia7712
approved these changes
Jan 9, 2025
chia7712
changed the title
LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA (1/N)LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA
chia7712
pushed a commit
that referenced
this pull request
Jan 9, 2025
…`STOP_REPLICA`, `UPDATE_METADATA` (#18417) Delete the handlers for LEADER_AND_ISR, STOP_REPLICA, and UPDATE_METADATA. Also, remove the corresponding unit tests in KafkaApisTest. Reviewers: Chia-Ping Tsai <[email protected]>
askew
pushed a commit
to askew/kafka
that referenced
this pull request
Jan 23, 2025
…`STOP_REPLICA`, `UPDATE_METADATA` (apache#18417) Delete the handlers for LEADER_AND_ISR, STOP_REPLICA, and UPDATE_METADATA. Also, remove the corresponding unit tests in KafkaApisTest. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18399
I will deal with these Api handler in this PR
Committer Checklist (excluded from commit message)